Skip to content

fix(index): remove redundant for-range loops if there is no index at that level#101

Merged
wenchy merged 3 commits intomasterfrom
redundant-indexes
Jun 7, 2025
Merged

fix(index): remove redundant for-range loops if there is no index at that level#101
wenchy merged 3 commits intomasterfrom
redundant-indexes

Conversation

@Kybxd
Copy link
Copy Markdown
Collaborator

@Kybxd Kybxd commented Jun 7, 2025

Also remove redundant flag.Parse() in main.go since examples in protogen package show that there is no need to call it manually

Comment thread test/go-tableau-loader/protoconf/loader/item_conf.pc.go
Copy link
Copy Markdown
Member

@wenchy wenchy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wenchy wenchy merged commit 7acecc9 into master Jun 7, 2025
@wenchy wenchy deleted the redundant-indexes branch June 7, 2025 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants