Skip to content

cpp(BREAKING)!: support both global-level and messager-level load options#117

Merged
Kybxd merged 9 commits intomasterfrom
cpp-loader-messager-options
Aug 15, 2025
Merged

cpp(BREAKING)!: support both global-level and messager-level load options#117
Kybxd merged 9 commits intomasterfrom
cpp-loader-messager-options

Conversation

@wenchy
Copy link
Copy Markdown
Member

@wenchy wenchy commented Aug 14, 2025

Related PRs

C++ standard requirement

  • At least C++17

❗BREAKING CHANGE

We split the LoadOptions into two kinds:

  1. LoadOptions: global-level options for Hub::Load.
  2. MessagerOptions: messager-level options for Messager::Load.

So when setting Hub::Load options for messager-level options, there are some differences compared to before.

Compatibility resolution

paths

options->paths["XXXConf"] = "./path/to/XXXConf.jsonn";
// changed to
auto mopts = std::make_shared<tableau::MessagerOptions>();
mopts->path ="./path/to/XXXConf.jsonn";
options->messager_options["XXXConf"] = mopts;

patch_paths

options->patch_paths["PatchXXXConf"] = {"./path/to/PatchXXXConf.json"};
// changed to
auto mopts = std::make_shared<tableau::MessagerOptions>();
mopts->patch_paths = {"./path/to/PatchXXXConf.json"};
options->messager_options["PatchXXXConf"] = mopts;

@wenchy wenchy requested a review from Kybxd August 15, 2025 03:06
@Kybxd Kybxd merged commit 6be8ad0 into master Aug 15, 2025
@Kybxd Kybxd deleted the cpp-loader-messager-options branch August 15, 2025 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants