Skip to content

feat(design): use messager Name() accesser for consistent design and improve C++ filepath process#119

Merged
Kybxd merged 5 commits intomasterfrom
messager-name-getter
Aug 15, 2025
Merged

feat(design): use messager Name() accesser for consistent design and improve C++ filepath process#119
Kybxd merged 5 commits intomasterfrom
messager-name-getter

Conversation

@wenchy
Copy link
Copy Markdown
Member

@wenchy wenchy commented Aug 15, 2025

No description provided.

@wenchy wenchy requested a review from Kybxd August 15, 2025 11:20
Comment thread cmd/protoc-gen-cpp-tableau-loader/embed/logger.pc.cc Outdated
/***** Synchronous Loading *****/
// Load fills messages (in MessagerContainer) from files in the specified directory and format.
bool Load(const std::string& dir, Format fmt = Format::kJSON, std::shared_ptr<const LoadOptions> options = nullptr);
bool Load(const std::filesystem::path& dir, Format fmt = Format::kJSON, std::shared_ptr<const LoadOptions> options = nullptr);
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing #include <filesystem>

Comment thread test/cpp-tableau-loader/src/protoconf/hero_conf.pc.h
@wenchy wenchy changed the title feat: use messager Name() accesser for consistent design feat: use messager Name() accesser for consistent design and improve C++ filepath process Aug 15, 2025
@wenchy wenchy changed the title feat: use messager Name() accesser for consistent design and improve C++ filepath process feat(design): use messager Name() accesser for consistent design and improve C++ filepath process Aug 15, 2025
@Kybxd Kybxd merged commit e102d76 into master Aug 15, 2025
@Kybxd Kybxd deleted the messager-name-getter branch August 15, 2025 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants