Skip to content

go: allow calling Name() when messager is nil#132

Closed
Kybxd wants to merge 1 commit intomasterfrom
fetch-messager-name-from-nil
Closed

go: allow calling Name() when messager is nil#132
Kybxd wants to merge 1 commit intomasterfrom
fetch-messager-name-from-nil

Conversation

@Kybxd
Copy link
Copy Markdown
Collaborator

@Kybxd Kybxd commented Aug 29, 2025

Method Name() of class Messager is static in cpp loader, so access to its name is allowed without a messager instance. We should keep same logic in go.

@Kybxd Kybxd changed the title feat: allow calling Name() when messager is nil go: allow calling Name() when messager is nil Aug 29, 2025
Comment thread test/go-tableau-loader/protoconf/loader/hero_conf.pc.go
@wenchy wenchy marked this pull request as draft September 9, 2025 08:24
@wenchy
Copy link
Copy Markdown
Member

wenchy commented Nov 29, 2025

After deep discusstion, the PR #109 needs this feature although it is not a clear and graceful solution.
Maybe in the future, we can generate the name string directly for clarity.

@wenchy wenchy closed this Nov 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants