Skip to content

feat(BREAKING)!: flatten index key as finder arguments#136

Merged
wenchy merged 3 commits intomasterfrom
flatten-index-key
Sep 20, 2025
Merged

feat(BREAKING)!: flatten index key as finder arguments#136
wenchy merged 3 commits intomasterfrom
flatten-index-key

Conversation

@Kybxd
Copy link
Copy Markdown
Collaborator

@Kybxd Kybxd commented Sep 16, 2025

Breaking change

Multiple-column index finder arguments are changed from the key struct to flattened params.

Go

// Previous
func (x *ItemConf) FindAwardItem(key ItemConf_Index_AwardItemKey) []*protoconf.ItemConf_Item {
    ...
}
// Current
func (x *ItemConf) FindAwardItem(id uint32, name string) []*protoconf.ItemConf_Item {
    ...
}

Cpp

// Previous
const Index_AwardItemVector* FindAwardItem(const Index_AwardItemKey& key) const;
// Current
const Index_AwardItemVector* FindAwardItem(uint32_t id, const std::string& name) const;

Add Map suffix when access underlying hash or ordered map

// Previous
const ItemConf::Index_AwardItemMap& ItemConf::FindAwardItem() const
// Current
const ItemConf::Index_AwardItemMap& ItemConf::FindAwardItemMap() const

Comment thread test/cpp-tableau-loader/src/protoconf/item_conf.pc.h Outdated
Comment thread test/cpp-tableau-loader/src/protoconf/item_conf.pc.cc Outdated
Comment thread test/go-tableau-loader/protoconf/loader/item_conf.pc.go
@wenchy wenchy merged commit fe787c1 into master Sep 20, 2025
@wenchy wenchy deleted the flatten-index-key branch September 20, 2025 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Index(multi-col): improve usability of FindXXX APIs

2 participants