Skip to content

perf(cpp)(BREAKING)!: encapsulate messager container to improve messager access performance#95

Merged
wenchy merged 14 commits intomasterfrom
perf-messager-getters-cpp
May 6, 2025
Merged

perf(cpp)(BREAKING)!: encapsulate messager container to improve messager access performance#95
wenchy merged 14 commits intomasterfrom
perf-messager-getters-cpp

Conversation

@Kybxd
Copy link
Copy Markdown
Collaborator

@Kybxd Kybxd commented Apr 24, 2025 •
edited by wenchy
Loading

❗BREAKING CHANGE

The plugin protoc-gen-cpp-tableau-loader parameters changed:

  1. registry-shards -> shards
  2. mode registry -> mode hub

Compatibility resolution

protoc options:

  • --cpp-tableau-loader_opt=mode=registry -> --cpp-tableau-loader_opt=mode=hub
  • --cpp-tableau-loader_opt=registry-shards=2 -> --cpp-tableau-loader_opt=shards=2

@wenchy wenchy changed the title feat(cpp): add messager container for better performance in accessing messagers perf(cpp): encapsulate messager container to improve messager access performance Apr 24, 2025
wenchy
wenchy requested changes Apr 24, 2025
View reviewed changes
Comment thread test/cpp-tableau-loader/src/protoconf/hub.pc.h Outdated
@Kybxd Kybxd force-pushed the perf-messager-getters-cpp branch from a989b38 to 52f016b Compare April 24, 2025 09:28
wenchy
wenchy requested changes Apr 24, 2025
View reviewed changes
Comment thread cmd/protoc-gen-cpp-tableau-loader/embed.go Outdated
Comment thread cmd/protoc-gen-cpp-tableau-loader/embed.go Outdated
Comment thread test/cpp-tableau-loader/src/protoconf/hub.pc.h
wenchy
wenchy requested changes Apr 25, 2025
View reviewed changes
Comment thread test/cpp-tableau-loader/src/protoconf/hub.pc.h Outdated
wenchy
wenchy requested changes Apr 25, 2025
View reviewed changes
Comment thread test/cpp-tableau-loader/src/protoconf/hub.pc.cc Outdated
wenchy
wenchy requested changes Apr 25, 2025
View reviewed changes
Comment thread cmd/protoc-gen-cpp-tableau-loader/main.go Outdated
Comment thread cmd/protoc-gen-cpp-tableau-loader/sharded.go
Comment thread test/cpp-tableau-loader/src/main.cpp
@Kybxd Kybxd changed the title perf(cpp): encapsulate messager container to improve messager access performance perf(cpp)(BREAKING!): encapsulate messager container to improve messager access performance Apr 25, 2025
@wenchy wenchy changed the title perf(cpp)(BREAKING!): encapsulate messager container to improve messager access performance perf(cpp)(BREAKING)!: encapsulate messager container to improve messager access performance May 6, 2025
@wenchy wenchy merged commit 3da116e into master May 6, 2025
@wenchy wenchy deleted the perf-messager-getters-cpp branch May 6, 2025 07:03
@Kybxd Kybxd mentioned this pull request Jul 17, 2025
Merged
@wenchy wenchy mentioned this pull request Aug 15, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wenchy wenchy wenchy approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

perf(cpp): get a specific messager by codegen without accessing MessagerMap cpp: upgrade to C++17 and use filesystem library instead

2 participants

@Kybxd @wenchy