Skip to content

table(union): support horizontal/vertical union list#128

Merged
wenchy merged 6 commits intomasterfrom
feat/support-list-of-union-in-table
Aug 20, 2024
Merged

table(union): support horizontal/vertical union list#128
wenchy merged 6 commits intomasterfrom
feat/support-list-of-union-in-table

Conversation

@Kybxd
Copy link
Copy Markdown
Collaborator

@Kybxd Kybxd commented Aug 19, 2024

@Kybxd Kybxd force-pushed the feat/support-list-of-union-in-table branch from ed78d8f to 19175bc Compare August 19, 2024 13:24
@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 19, 2024

Codecov Report

Attention: Patch coverage is 58.20896% with 28 lines in your changes missing coverage. Please review.

Project coverage is 55.13%. Comparing base (461824e) to head (b197d85).
Report is 1 commits behind head on master.

Files Patch % Lines
internal/confgen/parser.go 57.57% 16 Missing and 12 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #128      +/-   ##
==========================================
+ Coverage   55.11%   55.13%   +0.02%     
==========================================
  Files          74       74              
  Lines        9158     9185      +27     
==========================================
+ Hits         5047     5064      +17     
- Misses       3561     3566       +5     
- Partials      550      555       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wenchy wenchy changed the title feat: support list of union in table table(union): support horizontal/vertical union list Aug 20, 2024
@Kybxd Kybxd force-pushed the feat/support-list-of-union-in-table branch from 2cc34ed to 1372211 Compare August 20, 2024 02:53
@wenchy wenchy mentioned this pull request Aug 20, 2024
42 tasks
Copy link
Copy Markdown
Member

@wenchy wenchy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wenchy wenchy merged commit 82e5b05 into master Aug 20, 2024
@wenchy wenchy deleted the feat/support-list-of-union-in-table branch August 20, 2024 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

union: support horizontal/vertical union list

2 participants