Skip to content

protogen: support multiple enum definitions in a sheet#172

Merged
Kybxd merged 8 commits intomasterfrom
multi-type-definitions-in-sheet
Feb 13, 2025
Merged

protogen: support multiple enum definitions in a sheet#172
Kybxd merged 8 commits intomasterfrom
multi-type-definitions-in-sheet

Conversation

@wenchy
Copy link
Copy Markdown
Member

@wenchy wenchy commented Feb 12, 2025

@wenchy wenchy changed the title protogen: support multiple enum/struct/union type definitions in a sheet protogen: support multiple enum definitions in a sheet Feb 12, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 13, 2025

Codecov Report

Attention: Patch coverage is 77.51938% with 29 lines in your changes missing coverage. Please review.

Project coverage is 63.58%. Comparing base (2efbff9) to head (58e7a9b).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
internal/protogen/protogen.go 61.81% 15 Missing and 6 partials ⚠️
internal/protogen/util.go 83.78% 4 Missing and 2 partials ⚠️
internal/importer/book/table.go 95.23% 1 Missing ⚠️
internal/protogen/exporter.go 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #172      +/-   ##
==========================================
+ Coverage   63.36%   63.58%   +0.22%     
==========================================
  Files          74       74              
  Lines        9972    10079     +107     
==========================================
+ Hits         6319     6409      +90     
- Misses       3068     3079      +11     
- Partials      585      591       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wenchy wenchy marked this pull request as draft February 13, 2025 03:57
@wenchy wenchy marked this pull request as ready for review February 13, 2025 09:34
Copy link
Copy Markdown
Collaborator

@Kybxd Kybxd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Kybxd Kybxd merged commit 1ea50e2 into master Feb 13, 2025
@Kybxd Kybxd deleted the multi-type-definitions-in-sheet branch February 13, 2025 09:44
@wenchy wenchy mentioned this pull request Sep 25, 2024
42 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

protogen: support multiple enum type definitions in a sheet

2 participants