Skip to content

protogen: support multiple struct type definitions in a sheet#175

Merged
Kybxd merged 2 commits intomasterfrom
multi-struct-definitions-in-sheet
Feb 14, 2025
Merged

protogen: support multiple struct type definitions in a sheet#175
Kybxd merged 2 commits intomasterfrom
multi-struct-definitions-in-sheet

Conversation

@wenchy
Copy link
Copy Markdown
Member

@wenchy wenchy commented Feb 13, 2025

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 13, 2025

Codecov Report

Attention: Patch coverage is 74.67532% with 39 lines in your changes missing coverage. Please review.

Project coverage is 63.62%. Comparing base (1ea50e2) to head (a07c616).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
internal/protogen/protogen.go 67.21% 13 Missing and 7 partials ⚠️
internal/protogen/sheet_mode.go 77.64% 13 Missing and 6 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #175      +/-   ##
==========================================
+ Coverage   63.58%   63.62%   +0.04%     
==========================================
  Files          74       75       +1     
  Lines       10079    10162      +83     
==========================================
+ Hits         6409     6466      +57     
- Misses       3079     3096      +17     
- Partials      591      600       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Copy Markdown
Collaborator

@Kybxd Kybxd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Kybxd Kybxd merged commit 6039b69 into master Feb 14, 2025
@Kybxd Kybxd deleted the multi-struct-definitions-in-sheet branch February 14, 2025 03:31
@wenchy wenchy mentioned this pull request Sep 25, 2024
42 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

protogen: support multiple struct type definitions in a sheet

2 participants