Skip to content

union: support occupying horizontal multiple fields for list field#182

Merged
wenchy merged 13 commits intomasterfrom
feat/union-horizontal-extension
Mar 15, 2025
Merged

union: support occupying horizontal multiple fields for list field#182
wenchy merged 13 commits intomasterfrom
feat/union-horizontal-extension

Conversation

@Kybxd
Copy link
Copy Markdown
Collaborator

@Kybxd Kybxd commented Feb 28, 2025

  • If a union field has property: cross:x(x not zero), it occupies x fields of this union. For example, if a union's Field2 has type []int64|{cross:3}, it occupies 3 fields (Field2, Field3, Field4), and if a next field exists, it should be defined at Field5.
  • If a union field has property: cross:-1, it occupies all following fields of this union. No next field should exist after a cross:-1 field.

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 28, 2025

Codecov Report

Attention: Patch coverage is 75.09091% with 137 lines in your changes missing coverage. Please review.

Project coverage is 68.76%. Comparing base (cd9e3b1) to head (91af022).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
internal/confgen/table_parser.go 76.90% 54 Missing and 25 partials ⚠️
internal/confgen/document_parser.go 55.12% 27 Missing and 8 partials ⚠️
internal/confgen/parser.go 80.28% 8 Missing and 6 partials ⚠️
internal/protogen/protogen.go 66.66% 3 Missing and 3 partials ⚠️
log/logger.go 60.00% 2 Missing ⚠️
internal/protogen/exporter.go 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #182      +/-   ##
==========================================
+ Coverage   68.01%   68.76%   +0.74%     
==========================================
  Files          76       76              
  Lines        9699     9649      -50     
==========================================
+ Hits         6597     6635      +38     
+ Misses       2511     2444      -67     
+ Partials      591      570      -21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread proto/tableau/protobuf/tableau.proto Outdated
@Kybxd Kybxd changed the title union: support horizontal extension for the last list field union: support horizontal extension for list fields Mar 1, 2025
Comment thread test/functest/proto/excel__union__union.proto Outdated
Comment thread internal/confgen/document_parser.go Outdated
Comment thread internal/confgen/document_parser.go Outdated
Comment thread internal/confgen/parser.go Outdated
@wenchy wenchy changed the title union: support horizontal extension for list fields union: support occupying horizontal multiple fields for list field Mar 14, 2025
@wenchy wenchy force-pushed the feat/union-horizontal-extension branch from 0e73be9 to 13c1652 Compare March 14, 2025 12:35
Comment thread test/functest/proto/common/union.proto Outdated
Comment thread proto/tableau/protobuf/tableau.proto Outdated
@wenchy wenchy mentioned this pull request Feb 15, 2025
42 tasks
@wenchy wenchy merged commit 4cb6849 into master Mar 15, 2025
8 checks passed
@wenchy wenchy deleted the feat/union-horizontal-extension branch March 15, 2025 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

union: if the last field of a union is an incell list, extend it just like a horizontal list

2 participants