Skip to content

FieldProp(BREAKING!): support unique check of any field in list/map element#205

Merged
wenchy merged 21 commits intomasterfrom
feat/unique
Apr 12, 2025
Merged

FieldProp(BREAKING!): support unique check of any field in list/map element#205
wenchy merged 21 commits intomasterfrom
feat/unique

Conversation

@Kybxd
Copy link
Copy Markdown
Collaborator

@Kybxd Kybxd commented Mar 28, 2025

❗BREAKING CHANGE

If field prop unique is set in map field in a table sheet (Excel/CSV), it will now be generated to scalar field key's field prop of map value, but not the map field itself.

Compatibility resolution

If field prop unique is set in map field in a table sheet (Excel/CSV), please regenerate its proto files for upgrading.
For example:
image

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 28, 2025

Codecov Report

Attention: Patch coverage is 79.75460% with 66 lines in your changes missing coverage. Please review.

Project coverage is 69.70%. Comparing base (5f9966c) to head (d9d8d66).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
internal/confgen/parser.go 75.00% 22 Missing and 8 partials ⚠️
internal/confgen/table_parser.go 86.15% 14 Missing and 4 partials ⚠️
xerrors/ecode.go 0.00% 9 Missing ⚠️
internal/confgen/document_parser.go 90.19% 4 Missing and 1 partial ⚠️
internal/confgen/util.go 66.66% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #205      +/-   ##
==========================================
+ Coverage   69.41%   69.70%   +0.29%     
==========================================
  Files          79       79              
  Lines        9893    10033     +140     
==========================================
+ Hits         6867     6994     +127     
- Misses       2450     2463      +13     
  Partials      576      576              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@wenchy wenchy changed the title feat(BREAKING!): support non-key field uniqueness FieldProp(BREAKING!): support non-key field uniqueness Mar 29, 2025
@wenchy wenchy changed the title FieldProp(BREAKING!): support non-key field uniqueness FieldProp(BREAKING!): support unique check of any field in list/map element Apr 10, 2025
@wenchy wenchy mentioned this pull request Apr 11, 2025
42 tasks
@wenchy wenchy merged commit 2b12be0 into master Apr 12, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FieldProp(unique): support unique check of any field in list/map element confgen(KeyedList): auto deduce whether the list key is unique

2 participants