Skip to content

confgen(table): add a specifier to ignore some rows#259

Merged
wenchy merged 14 commits intomasterfrom
ingore-rows
Nov 17, 2025
Merged

confgen(table): add a specifier to ignore some rows#259
wenchy merged 14 commits intomasterfrom
ingore-rows

Conversation

@Kybxd
Copy link
Copy Markdown
Collaborator

@Kybxd Kybxd commented Jun 19, 2025

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 19, 2025

Codecov Report

❌ Patch coverage is 76.21145% with 54 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.19%. Comparing base (ac6d278) to head (4be93cf).
⚠️ Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
internal/confgen/table_parser.go 78.23% 29 Missing and 3 partials ⚠️
internal/importer/book/row.go 73.80% 8 Missing and 3 partials ⚠️
internal/importer/book/table_transpose.go 75.00% 4 Missing ⚠️
internal/protogen/protogen.go 0.00% 3 Missing ⚠️
internal/importer/book/table.go 50.00% 2 Missing ⚠️
internal/x/xproto/value.go 60.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #259      +/-   ##
==========================================
+ Coverage   74.12%   74.19%   +0.06%     
==========================================
  Files          82       83       +1     
  Lines        8361     8371      +10     
==========================================
+ Hits         6198     6211      +13     
- Misses       1586     1588       +2     
+ Partials      577      572       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread internal/importer/book/cell.go Outdated
Comment thread internal/x/xproto/value.go
@wenchy wenchy changed the title confgen(table): add a specifier to ingore some rows confgen(table): add a specifier to ignore some rows Sep 22, 2025
Comment thread internal/x/xproto/value.go
Comment thread internal/importer/book/cell.go Outdated
Comment thread internal/x/xproto/value.go
Comment thread internal/x/xproto/value.go
Comment thread internal/importer/book/cell.go Outdated
@wenchy wenchy merged commit 3b36597 into master Nov 17, 2025
9 checks passed
@wenchy wenchy deleted the ingore-rows branch November 17, 2025 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

confgen(IgnoreRows): add a specifier to ignore some rows of data

2 participants