Conversation
Member
wenchy
commented
Jan 6, 2026
wenchy
commented
- close confgen(Merger/Scatter): add support match shell file name pattern for SheetSpecifier #330
- close confgen(Merger/Scatter): duplicate generating the main sheet when multiple sheets exist in the same workbook #335
…ut duplicate sheets in multiple book name and sheet name patterns
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #341 +/- ##
==========================================
- Coverage 75.17% 75.15% -0.02%
==========================================
Files 85 85
Lines 8567 8569 +2
==========================================
Hits 6440 6440
- Misses 1561 1563 +2
Partials 566 566 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Kybxd
approved these changes
Jan 6, 2026
| // 2. exclude primary sheet, and auto filter out duplicate importers | ||
| // 3. special process for CSV filename pattern: "<BookName>#<SheetName>.csv" | ||
| func GetScatterImporters(ctx context.Context, inputDir, primaryBookName, sheetName string, scatterSpecifiers []string, subdirRewrites map[string]string) ([]ImporterInfo, error) { | ||
| func GetScatterImporters(ctx context.Context, inputDir, primaryBookName, primarySheetName string, sheetSpecifiers []string, subdirRewrites map[string]string) ([]ImporterInfo, error) { |
Collaborator
There was a problem hiding this comment.
is it possible to reuse same code between GetScatterImporters and GetMergerImporters?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.