feat: Add AsRat() *big.Rat for fractions for easy use and refactor fraction comparison#396
Open
feat: Add AsRat() *big.Rat for fractions for easy use and refactor fraction comparison#396
AsRat() *big.Rat for fractions for easy use and refactor fraction comparison#396Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #396 +/- ##
==========================================
- Coverage 74.05% 74.04% -0.02%
==========================================
Files 87 87
Lines 8819 8806 -13
==========================================
- Hits 6531 6520 -11
+ Misses 1718 1716 -2
Partials 570 570 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This MR introduces significant improvements to the fraction comparison functionality in the wellknown utility package:
Changes Made
math/big.Ratfor precise fraction comparisonsFraction.AsRat()method: Converts Fraction protobuf messages tobig.Rattype for mathematical operationsFraction.Cmp()method: Provides a cleaner interface for comparing fractions using comparator objectsLocalTimefunction: Eliminated unused timestamp utility that was redundant with protobuf's built-in functionalityBenefits
math/big.Ratprovides exact rational number arithmetic, eliminating potential integer overflow issuesTesting
Discussion
tableaupb.Fraction's field type fromint32toint64to adapt to*big.Rat?