Skip to content

feat: some enhancements#59

Merged
huieric merged 24 commits intomasterfrom
auto-deduce-main-worksheet
Jul 7, 2023
Merged

feat: some enhancements#59
huieric merged 24 commits intomasterfrom
auto-deduce-main-worksheet

Conversation

@wenchy
Copy link
Copy Markdown
Member

@wenchy wenchy commented Apr 19, 2023

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 19, 2023

Codecov Report

Merging #59 (a761b5a) into master (fb49419) will increase coverage by 4.74%.
The diff coverage is 44.44%.

@@            Coverage Diff             @@
##           master      #59      +/-   ##
==========================================
+ Coverage   42.27%   47.02%   +4.74%     
==========================================
  Files          31       36       +5     
  Lines        4054     5555    +1501     
==========================================
+ Hits         1714     2612     +898     
- Misses       2186     2658     +472     
- Partials      154      285     +131     
Flag Coverage Δ
unittests 47.02% <44.44%> (+4.74%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
internal/importer/excel.go 32.55% <0.00%> (-0.52%) ⬇️
internal/xproto/value.go 8.76% <0.00%> (ø)
internal/fs/path.go 12.50% <12.50%> (ø)
internal/confgen/parser.go 19.06% <22.22%> (ø)
internal/confgen/util.go 53.28% <22.85%> (ø)
internal/confgen/confgen.go 44.73% <33.33%> (ø)
internal/protogen/parser.go 35.47% <37.50%> (+7.32%) ⬆️
internal/confgen/prop/refer.go 59.86% <50.00%> (+42.96%) ⬆️
internal/importer/importer.go 62.88% <64.93%> (+9.63%) ⬆️
internal/fs/util.go 57.01% <65.51%> (+55.40%) ⬆️
... and 7 more

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@wenchy wenchy force-pushed the auto-deduce-main-worksheet branch from dac0d7b to 8d9d17f Compare May 16, 2023 13:41
@wenchy wenchy requested review from Kybxd and huieric May 16, 2023 17:31
@wenchy wenchy marked this pull request as draft May 16, 2023 17:43
@wenchy wenchy changed the title fix: some critical bug fixes feat: some enhancements Jun 14, 2023
@wenchy wenchy marked this pull request as ready for review July 6, 2023 08:29
Copy link
Copy Markdown
Member

@huieric huieric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@huieric huieric merged commit 2a8e88d into master Jul 7, 2023
@wenchy wenchy mentioned this pull request Jun 12, 2023
42 tasks
@wenchy wenchy deleted the auto-deduce-main-worksheet branch March 13, 2024 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants