Skip to content

feat(confgen): auto deduce whether the map key is unique#96

Merged
wenchy merged 13 commits intomasterfrom
feat/auto-detect-map-unique
May 14, 2024
Merged

feat(confgen): auto deduce whether the map key is unique#96
wenchy merged 13 commits intomasterfrom
feat/auto-detect-map-unique

Conversation

@Kybxd
Copy link
Copy Markdown
Collaborator

@Kybxd Kybxd commented May 13, 2024

@Kybxd Kybxd changed the title feat(confgen): auto detect map unique feat(confgen): auto deduce map unique May 13, 2024
@codecov
Copy link
Copy Markdown

codecov Bot commented May 13, 2024

Codecov Report

Attention: Patch coverage is 44.44444% with 80 lines in your changes are missing coverage. Please review.

Project coverage is 65.92%. Comparing base (f3733a9) to head (9099170).

Files Patch % Lines
internal/confgen/parser.go 33.33% 72 Missing and 8 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #96      +/-   ##
==========================================
+ Coverage   64.77%   65.92%   +1.14%     
==========================================
  Files          39       40       +1     
  Lines        4599     4625      +26     
==========================================
+ Hits         2979     3049      +70     
+ Misses       1241     1194      -47     
- Partials      379      382       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Kybxd Kybxd force-pushed the feat/auto-detect-map-unique branch from bcf2dad to 76ac599 Compare May 13, 2024 14:21
Comment thread internal/localizer/i18n/config/ecode/en.yaml Outdated
Comment thread internal/localizer/i18n/config/ecode/zh.yaml Outdated
Comment thread xerrors/ecode.go Outdated
Comment thread xerrors/ecode.go Outdated
Comment thread internal/confgen/parser.go Outdated
@wenchy wenchy changed the title feat(confgen): auto deduce map unique feat(confgen): auto deduce whether the map key is unique May 14, 2024
Copy link
Copy Markdown
Member

@wenchy wenchy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wenchy wenchy merged commit 49ea8d7 into master May 14, 2024
@wenchy wenchy deleted the feat/auto-detect-map-unique branch June 24, 2024 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

confgen: auto deduce whether the map key is unique

2 participants