Skip to content

ObjTree print update and cast fix (issue #64)#72

Open
donofrio wants to merge 2 commits into
obj_treefrom
objtree_cast_print
Open

ObjTree print update and cast fix (issue #64)#72
donofrio wants to merge 2 commits into
obj_treefrom
objtree_cast_print

Conversation

@donofrio
Copy link
Copy Markdown

Addresses two items in #64

  1. print -r N component does not print top level component - fixed. We now serialize on a recursive print request if the underlying component is not yet serialized. This allows for a recursive print

  2. Compiler warnings: in the hasChanged() function of FloatObj there was a incorrect cast to int64 rather than long double

  3. Misc dead code removal

@github-actions
Copy link
Copy Markdown

CLANG-FORMAT TEST - FAILED (on last commit):
Run > ./scripts/clang-format-test.sh using clang-format v20 to check formatting

}else{
os << val_->getName() << "/ (" << compInfo_->getType() << ")" << std::endl;
}
}
Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This addresses the ls -ll printing the component name

Copy link
Copy Markdown
Collaborator

@kpgriesser kpgriesser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I concur doctor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants