Quiet new gcc implicit-fallthrough warnings, and some minor Java lint#335
Merged
jcflack merged 2 commits intoREL1_6_STABLEfrom Nov 26, 2020
Merged
Quiet new gcc implicit-fallthrough warnings, and some minor Java lint#335jcflack merged 2 commits intoREL1_6_STABLEfrom
jcflack merged 2 commits intoREL1_6_STABLEfrom
Conversation
CI logs indicate some PG 13 builds, anyway, are giving -Wimplicit-fallthrough=3 to gcc. The gcc docs say with =3, a /*FALLTHROUGH*/ comment should be recognized. Warnings are also being generated for a switch in Type.c where they should not be: elog(ERROR is already marked with pg_unreachable in elog.h. I wonder whether adding an explicit pg_unreachable will work any better.
Not strictly related to the fallthrough business, but of the general nature of lint, and hardly worth a pull request of its own.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Travis builds against Linux PG13 were showing gcc invoked with
-Wimplicit-fallthrough=3, so quiet the warnings that result. I cannot explain why gcc is not respecting thepg_unreachablebuilt intoelog(ERRORbut does respect apg_unreachableadded right there in the code.