Skip to content

Fix bogus out-of-date Javadoc comments #454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jcflack merged 2 commits into from
Sep 5, 2023
Merged

Fix bogus out-of-date Javadoc comments #454

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e25b7c4
Clean up a bogus javadoc comment
jcflack Aug 24, 2023
8353f6f
Ax ancient Java version in PL/Java 1.6.x docs
jcflack Aug 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions pljava-api/src/main/java/org/postgresql/pljava/annotation/package-info.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2015-2016 Tada AB and other contributors, as listed below.
* Copyright (c) 2015-2023 Tada AB and other contributors, as listed below.
*
* All rights reserved. This program and the accompanying materials
* are made available under the terms of the The BSD 3-Clause License
Expand Down Expand Up @@ -33,11 +33,10 @@
* <p>
* Automatic descriptor generation requires attention to a few things.
* <ul>
* <li>A Java 6 or later Java compiler is required, and at least the
* <code>pljava-api</code> jar must be on its class path. (The full
* <code>pljava.jar</code> would also work, but only <code>pljava-api</code>
* is required.) The jar must be on the class path in any case in order to
* compile PL/Java code.
* <li>The {@code pljava-api} jar must be on the Java compiler's class path.
* (All but the simplest PL/Java functions probably refer to some class in
* PL/Java's API anyway, in which case the jar would already have to be on
* the class path.)
* <li>When recompiling after changing only a few sources, it is possible the
* Java compiler will only process a subset of the source files containing
* annotations. If so, it may generate an incomplete deployment descriptor,
Expand Down
11 changes: 5 additions & 6 deletions pljava/src/main/java/org/postgresql/pljava/internal/VarlenaWrapper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1182,12 +1182,11 @@ public Thread newThread(Runnable r)
* wraps a {@code ByteBuffer} and the {@link Output.State Output.State}
* that protects it.
*<p>
* {@code BufferWrapper} installs <em>itself</em> as the inherited
* {@code m_state} field, so {@code ByteBufferInputStream}'s methods
* synchronize on it rather than the {@code State} object, for no
* interference with the writing thread. The {@code pin} and
* {@code unpin} methods, of course, forward to those of the
* native state object.
* {@code BufferWrapper} installs <em>itself</em> as the
* {@code ByteBufferInputStream}'s lock object, so its methods
* synchronize on this rather than anything that would interfere with
* the writing thread. The {@code pin} and {@code unpin} methods,
* of course, forward to those of the native state object.
*/
static class BufferWrapper
extends ByteBufferInputStream
Expand Down