[lang] Update minimum requirement for CMAKE #8702
Closed
linull24 wants to merge 4 commits intotaichi-dev:masterfrom
Closed
[lang] Update minimum requirement for CMAKE #8702linull24 wants to merge 4 commits intotaichi-dev:masterfrom
linull24 wants to merge 4 commits intotaichi-dev:masterfrom
Conversation
This was referenced Apr 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: #8673
Brief Summary
copilot:summary
This PR resolves CMake 4.0 compilation failures by standardizing the minimum required version to 3.17 across all submodules (TaichiExamples/TaichiCAPITests/TaichiCAPI/TaichiTests), ensuring compatibility with modern Linux distributions.
Walkthrough
copilot:walkthrough
Context
Changes Made
TaichiExamples.cmakeTaichiCAPITests.cmakeTaichiCAPI.cmakeTaichiTests.cmakeImpact Analysis
Verification
Additional Notes
I sincerely apologize for the additional PR noise (#8701, #8678). Due to my initial lack of Git proficiency, I inadvertently created redundant PRs while attempting to sync with upstream. This new PR (#8702) consolidates all changes with proper rebasing.
Thank you for your patience, and I appreciate your guidance throughout this process.