Skip to content

perf: improve forge REPL readline performance#2912

Merged
tusharmath merged 5 commits intotailcallhq:mainfrom
Alexx999:pr-use-gix
Apr 13, 2026
Merged

perf: improve forge REPL readline performance#2912
tusharmath merged 5 commits intotailcallhq:mainfrom
Alexx999:pr-use-gix

Conversation

@Alexx999
Copy link
Copy Markdown
Contributor

@Alexx999 Alexx999 commented Apr 9, 2026

On some OS (such as, ahem, Windows) process spawning is expensive.
Forge prompt editor was extremely laggy for me, even simply moving the caret is slow on Windows.
I discounted it as "forge in zsh in msys2 in Windows Terminal" issue but it turned out to be "git process launch on any key press"

This speeds up the query massively, especially so on Windows.

@github-actions github-actions bot added the type: feature Brand new functionality, features, pages, workflows, endpoints, etc. label Apr 9, 2026
@Alexx999 Alexx999 force-pushed the pr-use-gix branch 2 times, most recently from fcccff7 to dd5faad Compare April 12, 2026 17:50
@tusharmath tusharmath changed the title Use gix instead of Command::new("git") perf: improve forge REPL readline performance Apr 13, 2026
@github-actions github-actions bot added ci: benchmark Runs benchmarks type: performance Improved performance. labels Apr 13, 2026
# Conflicts:
#	Cargo.lock
@tusharmath
Copy link
Copy Markdown
Collaborator

Its a shame we din't catch this before. Thank you so much for this PR! I made some additional improvements for performance.

@tusharmath tusharmath enabled auto-merge (squash) April 13, 2026 03:23
@tusharmath tusharmath merged commit 4aabbe7 into tailcallhq:main Apr 13, 2026
8 checks passed
@tusharmath tusharmath removed the type: feature Brand new functionality, features, pages, workflows, endpoints, etc. label Apr 13, 2026
@YvanDaSilva
Copy link
Copy Markdown

Hello @Alexx999 and @tusharmath,

Any reason why the Cargo.lock was removed?
This seems like a mistake as there is now no way to reproduce the dependencies properly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci: benchmark Runs benchmarks type: performance Improved performance.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants