feat: add metrics pipeline_resolver_graphql_steps_total and pipeline_resolver_function_steps_total#42
Conversation
…ne_resolver_function_steps_total`
Contributor
Code Metrics Report
Details | | main (347af8b) | #42 (b93a748) | +/- |
|---------------------|----------------|---------------|-------|
+ | Coverage | 26.6% | 27.5% | +0.9% |
| Files | 12 | 12 | 0 |
| Lines | 556 | 563 | +7 |
+ | Covered | 148 | 155 | +7 |
+ | Code to Test Ratio | 1:1.3 | 1:1.4 | +0.1 |
| Code | 1462 | 1483 | +21 |
+ | Test | 1924 | 2178 | +254 |
- | Test Execution Time | 6s | 8s | +2s |Code coverage of files in pull request scope (93.6% → 94.4%)
Reported by octocov |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds new metrics to track the number of GraphQL and Function steps within pipeline resolvers, updates the documentation accordingly, and introduces comprehensive tests to ensure correct metric calculation and coverage of edge cases.
Metrics collection enhancements:
pipeline_resolver_graphql_steps_totalandpipeline_resolver_function_steps_total, which count the number of GraphQL and Function steps in all pipeline resolvers, respectively. [1] [2] [3]README.mdto document these new metrics and their purpose.Testing improvements:
TestClient_Metrics_StepTypes) covering various scenarios for GraphQL and Function step counting, including mixed types, only one type, empty resources, and resolvers with no steps.