fixes approver list when it is greater than 10 approvers #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…is greater than 10, it shows a dropdown menu with all users instead. here we create a addBlockSuggestionHandler with all the approveremails, and create a dropdown to show that list instead of all users
Contributor
|
Thank you for improving this part of the approver selection, @rayzorinc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
When the
approverEmailslist is longer than 10 users, it will create a dropdown list of all users instead.This is non-intuitive to end users to know which person is part of the approver list.
Here we fix it by creating a valid approver list and creating the dropdown to only list those users.