Force timeout during connection#135
Conversation
|
ping @knyar & @patrickod & @willnorris |
| description: 'Optional state directory to use (if unset, memory state is used)' | ||
| required: false | ||
| default: '' | ||
| timeout: |
There was a problem hiding this comment.
I'd rather not expand the API surface of the action if we really don't need to. Users can already set the timeout on either the entire job or the step, so I'm not sure that having a configurable timeout is necessary here also.
There was a problem hiding this comment.
oh, I just noticed that the original issue this was fixing was specifically to add a configurable timeout. I'm still curious if the step timeout does not also accomplish the same thing?
| TAGS_ARG="--advertise-tags=${{ inputs.tags }}" | ||
| fi | ||
| timeout 5m sudo -E tailscale up ${TAGS_ARG} --authkey=${TAILSCALE_AUTHKEY} --hostname=${HOSTNAME} --accept-routes ${ADDITIONAL_ARGS} | ||
| timeout --verbose --kill-after=1s ${TIMEOUT} sudo -E tailscale up ${TAGS_ARG} --authkey=${TAILSCALE_AUTHKEY} --hostname=${HOSTNAME} --accept-routes ${ADDITIONAL_ARGS} |
There was a problem hiding this comment.
ooh, nice. I hadn't used --kill-after before. Definitely makes sense here if this timeout isn't taking effect.
There was a problem hiding this comment.
Correct, the timeout isnt working at all.
Please see #134
2 participants
Fixes #134