Conversation
oxtoacart
force-pushed
the
percy/issue201
branch
10 times, most recently
from
fc76a2f to
52aa03f
Compare
mpminardi
reviewed
Oct 14, 2025
| throw new Error(`tailscale status failed with exit code ${exitCode}`); | ||
| } | ||
| if (core.isDebug()) { | ||
| process.stdout.write(stdout); |
Member
There was a problem hiding this comment.
We do a core.debug call with the result of getTailscaleStatus later down the line, does this operate differently or should we remove one of these calls?
Collaborator
Author
There was a problem hiding this comment.
The later one shows round-tripped JSON that's not even pretty-printed, which isn't very useful. I'll just remove that one.
Collaborator
Author
|
The Windows unstable failure due to a shasum mismatch is unrelated to this PR and doesn't appear to be caused by a bug in the GitHub Action. |
Updates #201 Signed-off-by: Percy Wegmann <percy@tailscale.com>
oxtoacart
force-pushed
the
percy/issue201
branch
from
52aa03f to
cd672e4
Compare
mcoulombe
approved these changes
Oct 14, 2025
oxtoacart
commented
Oct 14, 2025
| // Check Tailscale status (cross-platform) | ||
| try { | ||
| const status = await getTailscaleStatus(); | ||
| core.debug(`Tailscale status: ${JSON.stringify(status)}`); |
Collaborator
Author
There was a problem hiding this comment.
This is redundant with stdout and less readable because it's been round-tripped and isn't pretty-printed.
mpminardi
approved these changes
Oct 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates #201
Example failure - https://github.com/tailscale/github-action/actions/runs/18510269746/job/52749289036?pr=202
Example success without logging
tailscale statusoutput - https://github.com/tailscale/github-action/actions/runs/18510309448/job/52749430752?pr=202Example success with logging
tailscale statusoutput because of ACTIONS_STEP_DEBUG - https://github.com/tailscale/github-action/actions/runs/18510420218/job/52749794030?pr=202