stop tailscale service after CI workload finishes#206
Conversation
0647183 to
eb7fea2
Compare
9090315 to
7f5fd03
Compare
7f5fd03 to
d22af2d
Compare
835c63c to
bd56b76
Compare
src/logout/logout.ts
Outdated
| } | ||
| // The pid is actually the pid of the `sudo` parent of tailscaled, so use pkill -P to kill children of that parent | ||
| await exec.exec("sudo", ["pkill", "-P", pid]); | ||
| core.info("✅ Stopped tailscaled"); |
There was a problem hiding this comment.
|
@oxtoacart I approved this, but I thought of a better way.
We could potential |
I tried this on my Mac, and it doesn't stop any running I do think it would be good to run after we kill
It would be nice to support Windows, let me try that. |
bd56b76 to
62c3225
Compare
62c3225 to
1ddc035
Compare
|
huh, that's sad. I do wonder if |
1ddc035 to
c75ca9e
Compare
We're not installing tailscale as a service, we're just spawning the tailscaled daemon manually. |
|
Here's a CI run with temporary logging code that shows us successfully stopping the tailscale daemon and |
c75ca9e to
7112c32
Compare
Updates #205 Signed-off-by: Percy Wegmann <percy@tailscale.com>
7112c32 to
1af04a5
Compare
Updates #205