Add GCS Support #18
Open
Add GCS Support #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds support for using Google Cloud Storage as a remote cache backend alongside the existing S3 support. Key changes: - Add gcsutil package for GCS operations - Add GCSCache implementation for build cache - Refactor storage backend to support both S3 and GCS - Add storage abstraction layer (CacheClient interface) - Add command-line flags for GCS configuration: --storage (s3|gcs) --gcs-bucket --gcs-key-file --gcs-concurrency - Rename lib/gobuild/gobuild.go to lib/gobuild/s3.go for clarity The implementation follows the same patterns as S3 support: - Concurrent uploads with configurable concurrency - ETag-based duplicate detection - Minimum upload size threshold - Metrics for cache hits/misses/uploads
Add GCS (Google Cloud Storage) backend support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From @avdasCrusoe Description:
This PR adds support for using Google Cloud Storage as a remote cache backend alongside the existing S3 support.
Key Changes
New Components
CacheClientinterface supporting both S3 and GCSS3AdapterandGCSAdapterimplementing unified interfaceCommand-Line Interface
--storage- Choose backend:s3orgcs--gcs-bucket- GCS bucket name--gcs-key-file- Path to GCS service account key file--gcs-concurrency- Maximum concurrency for GCS uploadsCode Organization
lib/gobuild/gobuild.go→lib/gobuild/s3.gofor claritymodproxyandrevproxyto use storage abstractionImplementation Details
The GCS implementation follows the same patterns as S3:
Backward Compatibility
--s3-bucket,--s3-region, etc.)Testing