server/token.go: change emailish emails into realish looking ones #69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The email claim for github and passkey logins will be expanded into user@passkey.<tsidp-hostname>.<tsname>.ts.net. This is a more realish looking email address that should be more compatible with clients. Updates #58 Signed-off-by: Benson Wong <benson@tailscale.com>
mostlygeek
force-pushed
the
mostlygeek/email-tld-issue-58
branch
from
6882f65 to
5b3696e
Compare
mikeodr
approved these changes
Sep 30, 2025
remyguercio
approved these changes
Sep 30, 2025
Contributor
remyguercio
left a comment
remyguercio
left a comment
There was a problem hiding this comment.
This LGTM and I think minimally fixes the issue at hand.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The email claim for github and passkey logins will be expanded into user@passkey...ts.net. This is a more valid looking email address to be more pragmatically compatible with clients.
Updates #58