server: move os.Exit() and panic() out of request handling paths #72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove os.Exit() and panic() calls that could cause tsidp to exit unexpectedly during an HTTP request. After this change tsidp will return a 500 internal server error to clients and log errors to stdout. Fixes #71 Signed-off-by: Benson Wong <benson@tailscale.com>
mikeodr
reviewed
Oct 1, 2025
Signed-off-by: Benson Wong <benson@tailscale.com>
Contributor
Author
|
@mikeodr I renamed the function as it no longer panics. |
mikeodr
approved these changes
Oct 1, 2025
Collaborator
mikeodr
left a comment
mikeodr
left a comment
There was a problem hiding this comment.
Should squash to 1 commit but LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove os.Exit() and panic() calls that could cause tsidp to exit unexpectedly during an HTTP request. After this change tsidp will return a 500 internal server error to clients and log errors to stdout.
Fixes #71