server: add app cap grant checking for /clients/ endpoint #79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mostlygeek
commented
Oct 6, 2025
| req := httptest.NewRequest("DELETE", "/clients/test-client-1", nil) | ||
| rr := httptest.NewRecorder() | ||
|
|
||
| s.serveDeleteClient(rr, req, "test-client-1") |
Contributor
Author
There was a problem hiding this comment.
changed to ServeHTTP to use app cap middleware.
mostlygeek
force-pushed
the
mostlygeek/client-app-cap
branch
from
59b3a3e to
d081ba3
Compare
mostlygeek
commented
Oct 6, 2025
| rr := httptest.NewRecorder() | ||
|
|
||
| s.serveGetClientsList(rr, req) | ||
| s.ServeHTTP(rr, req) |
Contributor
Author
There was a problem hiding this comment.
changed to ServeHTTP to use app cap middleware.
mostlygeek
commented
Oct 6, 2025
| rr := httptest.NewRecorder() | ||
|
|
||
| s.serveNewClient(rr, req) | ||
| s.ServeHTTP(rr, req) |
Contributor
Author
There was a problem hiding this comment.
changed to ServeHTTP to use app cap middleware.
mostlygeek
commented
Oct 6, 2025
| // Register /clients/ endpoint | ||
| // Migrated from legacy/tsidp.go:684 | ||
| mux.HandleFunc("/clients/", s.serveClients) | ||
| mux.HandleFunc("/clients/", s.addGrantAccessContext(s.serveClients)) |
Contributor
Author
There was a problem hiding this comment.
add middleware handler to inject the App Cap grant into r.Context
remyguercio
approved these changes
Oct 6, 2025
Contributor
remyguercio
left a comment
remyguercio
left a comment
There was a problem hiding this comment.
LGTM, and I agree that consolidation of endpoints to prevent misalignments like this is the path forward.
Member
|
@mostlygeek could you also add some tests that make sure that all non-public endpoints check the grants? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the /clients/ endpoint to require the allow_admin_ui capability grant added in #47.
Updates #78