Skip to content

Conversation

@mikeodr
Copy link
Collaborator

@mikeodr mikeodr commented Oct 14, 2025

mkPackageOption references pkgs, but the flake should reference
the local package first as a default as this is not upstream.

add meta.mainProgram to resolve warning.

Fix data dir arg.

@mikeodr mikeodr requested a review from mostlygeek October 14, 2025 23:36
@mikeodr
Copy link
Collaborator Author

mikeodr commented Oct 14, 2025

Resolves a broken flake in #81

Will test better next time.

@akotro if you have a better solve for this issue I'm all ears.

@mikeodr mikeodr force-pushed the mikeodr/fix-flake-pkg branch from 6b26a37 to b1a9451 Compare October 14, 2025 23:49
@mikeodr mikeodr force-pushed the mikeodr/fix-flake-pkg branch 4 times, most recently from e8855bb to a1d117f Compare October 15, 2025 00:06
flake.nix Outdated
log = cfg.settings.logLevel;
debug-all-requests = cfg.settings.debugAllRequests;
debug-tsnet = cfg.settings.debugTsnet;
dir = "/var/lib/tsidp";
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prob want to upstream this also @akotro

Without this all the config ends up in /var/lib/tsidp/.config/tsnet-tsidp/. When before it was just in /var/lib/tsidp/ on the pre-updated flake I had put together.

This broke what already existed in the repo for people using it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, I'll open a PR for it upstream.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I can handle it! Was just a passing comment on an unexpected delta.

I can tomorrow morning but if you beat me to it I won't stop you.

Appreciate the collaboration and updates in both places you've been doing!

@mikeodr mikeodr changed the title flake.nix: fix package set flake.nix: fix broken flake Oct 15, 2025
@mikeodr mikeodr self-assigned this Oct 15, 2025
@mikeodr mikeodr added the NixOS label Oct 15, 2025
@mikeodr mikeodr force-pushed the mikeodr/fix-flake-pkg branch from a1d117f to 9d97b5f Compare October 15, 2025 12:52
mkPackageOption references pkgs, but the flake should reference
the local package first as a default as this is not upstream.

add meta.mainProgram to resolve warning.

Fix data dir arg.

Signed-off-by: Mike O'Driscoll <mike@unusedbytes.ca>
@mikeodr mikeodr force-pushed the mikeodr/fix-flake-pkg branch from 9d97b5f to 1996cb8 Compare October 15, 2025 13:09
@mikeodr mikeodr merged commit 3877b43 into main Oct 15, 2025
2 checks passed
@mikeodr mikeodr deleted the mikeodr/fix-flake-pkg branch October 15, 2025 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants