Skip to content

Handle undefined/wrong menu types and properly remove classes on close#17

Merged
takien merged 3 commits intotakien:masterfrom
juliangut:master
Oct 26, 2014
Merged

Handle undefined/wrong menu types and properly remove classes on close#17
takien merged 3 commits intotakien:masterfrom
juliangut:master

Conversation

@juliangut
Copy link
Copy Markdown
Contributor

Basically:

  • Handle undefined/wrong menu types (line 40)
  • Properly assign classes to elements (line 47-48)
  • and remove classes on close (line 60)

Additionally remove closeOnClickInside as it was a carbon copy of closeOnClickOutside

It also would be nice to make the package available through bower by:

bower register jPushMenu git://github.com/takien/jPushMenu.git

because now if you look for it or try to install it through bower raises a Not Found error

btw sorry for the reformatting, my editor is configured to do so automatically

@takien
Copy link
Copy Markdown
Owner

takien commented Oct 26, 2014

great,
but, actually I have no idea how and what bower is.

takien pushed a commit that referenced this pull request Oct 26, 2014
Handle undefined/wrong menu types and properly remove classes on close
@takien takien merged commit 1e960b7 into takien:master Oct 26, 2014
@juliangut
Copy link
Copy Markdown
Contributor Author

Bower is a component dependency manager for javascript libraries.
You already have a .bower file in your code so anyone can clone your repository and do bower install to get the dependencies of jPushMenu automatically installed in bower_components directory.

But if I want to install jPushMenu through bower it's not possible because bower doesn't know anything about jPushMenu, it hasn't been registered yet:
If you like I can register it for you, it will point to your repository and be reachable through bower install jPushMenu automatically.
Versioning through bower uses your repository tags, so for bower to point to last version you need to add a new tag to current code, 1.1.2 for example

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants