This repository was archived by the owner on Feb 13, 2020. It is now read-only.
fix(git-import): updates spec for git import #92
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frontend/public/extend/devconsole/components/ImportFlowForm/__tests__/ImportFlowForm.spec.tsx
Show resolved
Hide resolved
frontend/public/extend/devconsole/components/ImportFlowForm/__tests__/ImportFlowForm.spec.tsx
Show resolved
Hide resolved
frontend/public/extend/devconsole/components/ImportFlowForm/__tests__/ImportFlowForm.spec.tsx
Outdated
Show resolved
Hide resolved
Collaborator
Author
|
@christianvogt thanks for the review. Have updated specs and added few more, PTAL |
invincibleJai
force-pushed
the
fix-git-import-spec
branch
3 times, most recently
from
f133d9d to
aeca7a8
Compare
frontend/public/extend/devconsole/components/ImportFlowForm/ImportFlowForm.tsx
Outdated
Show resolved
Hide resolved
invincibleJai
force-pushed
the
fix-git-import-spec
branch
from
aeca7a8 to
b0b335d
Compare
Collaborator
Author
|
@christianvogt have updated PR with some tests for pipelines as well PTAL, in case you missed. |
Collaborator
There was a problem hiding this comment.
For future reference:
With jest you can assert array lengths .toHaveLength(1).
https://jestjs.io/docs/en/expect.html#tohavelengthnumber
invincibleJai
force-pushed
the
fix-git-import-spec
branch
from
b0b335d to
05f3ce7
Compare
christianvogt
approved these changes
May 15, 2019
sanketpathak
pushed a commit
to sanketpathak/console
that referenced
this pull request
Jun 21, 2019
* fix(git-import): updates spec for git import * fix(pipelines-test): updates pipeline test and fixes review
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.