Skip to content

PLT-951 Add PHP 8 support#158

Open
mrliptontea wants to merge 19 commits intomasterfrom
PLT-951-add-php-8-support
Open

PLT-951 Add PHP 8 support#158
mrliptontea wants to merge 19 commits intomasterfrom
PLT-951-add-php-8-support

Conversation

@mrliptontea
Copy link
Copy Markdown
Member

@mrliptontea mrliptontea commented Mar 19, 2026 •
edited
Loading

  • PLT-951
  • Add PHP 8 support
  • Require ext-mongodb >= 1.7.0
    • Enforce that $readPreference is a string
    • Switch from ReadPreference->getMode() to getModeString()
  • Require psr/log instead of Monolog
    • Monolog is now a dev-only package
  • Add Resque compatibility layer
    • Allow library to work against current latest release but also development which includes namespace changes and also requires that job classes extend Resque\Job\Job.
  • Decouple Tripod\Mongo\Jobs\JobBase from Tripod\Mongo\DriverBase
    • Extract LoggerTrait from DriverBase
    • Few methods from DriverBase used by jobs were re-implemented.
    • Make Tripod\Mongo\Jobs\JobBase extend Resque\Job\Job.
  • Bump arc2 library
    • Allow versions 2 & 3.

@mrliptontea mrliptontea force-pushed the PLT-951-add-php-8-support branch from 0f63c9b to 0ada92c Compare March 19, 2026 15:05
mike-dean-talis
mike-dean-talis approved these changes Mar 20, 2026
View reviewed changes
Copy link
Copy Markdown

@mike-dean-talis mike-dean-talis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to an untrained tripod-ist.

@mrliptontea mrliptontea force-pushed the PLT-951-add-php-8-support branch 3 times, most recently from 20cf02f to 9611893 Compare March 24, 2026 12:56
@mrliptontea mrliptontea force-pushed the PLT-951-modernise-code branch 2 times, most recently from cb344a0 to ed05d27 Compare March 30, 2026 14:22
@mrliptontea mrliptontea force-pushed the PLT-951-add-php-8-support branch from 9611893 to 67a6c6c Compare March 30, 2026 14:44
@mrliptontea mrliptontea force-pushed the PLT-951-modernise-code branch 2 times, most recently from 630f821 to 8462d75 Compare March 31, 2026 07:57
@mrliptontea mrliptontea force-pushed the PLT-951-add-php-8-support branch from 67a6c6c to 1b2e02f Compare March 31, 2026 07:57
@mrliptontea mrliptontea force-pushed the PLT-951-modernise-code branch 2 times, most recently from e40d121 to 29a2458 Compare March 31, 2026 12:30
@mrliptontea mrliptontea force-pushed the PLT-951-add-php-8-support branch from 1b2e02f to fd9ef86 Compare March 31, 2026 14:04
Base automatically changed from PLT-951-modernise-code to master April 14, 2026 11:28
@mrliptontea
Make PHPStan use version range from composer.json
c75e93f
@mrliptontea
Remove unnecessary unset
d672217
@mrliptontea
Resolve ReflectionProperty::setAccessible() is deprecated
5f1dd5d 
ReflectionProperty::setAccessible() is deprecated since 8.5,
as it has no effect since PHP 8.1
@mrliptontea
Resolve null used as array offset
9b0f407 
Use an empty string instead, as null is silently converted:
php -r '$arr = ["" => "foo"]; var_dump($arr[null]);'
@mrliptontea mrliptontea force-pushed the PLT-951-add-php-8-support branch from fd9ef86 to 9b0f407 Compare April 14, 2026 11:33
@mrliptontea mrliptontea marked this pull request as ready for review April 14, 2026 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mike-dean-talis mike-dean-talis mike-dean-talis approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mrliptontea @mike-dean-talis