Merged
Conversation
vickz84259
approved these changes
Oct 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a bug that made the browser tab crash under certain conditions when
<Session>re-renders.<Session>has asyncUserprop that has the typeTalk.User | () => Talk.User.Sessionuses anuseEffectto destroy & reinitialize itself whenever the current user changes. However, passing the value ofsyncUserto theuseEffectdependency array directly would result in the session being destroyed even if the user ID never changed, becauseuseEffect's dependency array does a shallow comparison that fails whensyncUseris a non-memoized object/function.The bug is fixed by passing the user ID to the dependency array instead of
syncUser.