Fix uninitialized vars and sys call crash#54
Merged
tanelpoder merged 1 commit intotanelpoder:masterfrom Dec 11, 2024
Merged
Conversation
Owner
|
Thanks! (Man, I've been coding mostly Python for too long 😄) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just to get my feet wet here, I worked a bit to fix a crash I had noticed and shut up some compiler warnings in the next code.
The syscall issue is that reading orig_ax can be unpredictable sometimes when an interrupt happens while running the probe. It's rare, but I could see it once in a while when running locally. I think if we must find the syscall number we should put a kprobe on syscall kernel function, but I think this is probably an overkill.