fix: Sprint 22.6 — compile error + clippy 1.95 + failing tests + version sync#30
Merged
Merged
Conversation
… sync Bundles fixes for issues blocking CI on main and gives credit to community contribution from PR #27. ## Compile error (from PR #27) - src/generator/json_parser.rs:342 — pass &Value (not &&str) to validate_change_schema. Was E0308 blocking cargo test on main. ## Clippy 1.95 lints (deny-warnings on CI) - src/analysis/repo_intel.rs:281 — sort_by → sort_by_key + Reverse - src/analysis/ast_intel.rs (walk_import_nodes) — allow collapsible_match (refactoring to match guards would change fallthrough semantics) - src/pr/patrol.rs (check_single_pr) — allow collapsible_match same reason ## Failing tests (4) - ast_intel::test_multihop_2hop_resolution — 2-hop chain lookup must iterate file_imports.keys() (not parsed_files.keys()) so chains can follow files whose symbols haven't been parsed yet - guidelines::test_detect_ai_policy_ban — lowercase input inside the function so callers can pass mixed-case text - guidelines::test_detects_ai_ban_llm — added pattern matching "(LLM|GPT|...) generated/written/created code|contributions|prs" - guidelines::test_detects_ai_ban_manual_only — added pattern matching "only accept|allow|welcome manual|human contributions" ## Version sync (from PR #27) - Cargo.toml 6.0.0 → 6.2.0 (matches README badge) - install.sh / install.ps1 v5.2.0 → v6.2.0 Co-authored-by: Rudasingwa-kevin <Rudasingwa-kevin@users.noreply.github.com>
22 tasks
tang-vu
pushed a commit
that referenced
this pull request
Apr 27, 2026
Bumps tokio, clap, tree-sitter-c/php/c-sharp/css, uuid, rand, axum, axum-server, criterion. CI green on rust 1.95.0. Merged after #30 fixed pre-existing main breakage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Comprehensive cleanup that bundles the contributions from #27 with fixes for additional issues blocking CI on
main. Closes #27 (credit retained viaCo-authored-by).Issues fixed
1. Compile error (was blocking ALL PR CI)
crates/contribai-rs/src/generator/json_parser.rs:342—validate_change_schema(&invalid2)was passing&&strto a function expecting&serde_json::Value. E0308, originally caught by @Rudasingwa-kevin in chore: Update version to 6.2.0 in configuration and installation scripts #27.2. Clippy 1.95 lints (CI uses
-D warnings)repo_intel.rs:281— replacedsort_by(|a,b| b.score.cmp(&a.score))withsort_by_key(|b| std::cmp::Reverse(b.score))ast_intel.rs::walk_import_nodes&patrol.rs::check_single_pr— added#[allow(clippy::collapsible_match)]. Refactoring to match-arm guards would change fallthrough semantics for the JS/TS, Rust, Go, Java arms (current code ismatch Lang { Lang::X => if kind == "..." {...} }; converting theifto a guard would let unmatched kinds fall through to subsequent arms instead of doing nothing).3. Failing tests (4)
analysis::ast_intel::tests::test_multihop_2hop_resolution— 2-hop import resolution looked up file B inparsed_files.keys(). Fixed to iteratefile_imports.keys()so chains can follow files whose symbols haven't been parsed yet (which is the whole point of multi-hop).github::guidelines::tests::test_detect_ai_policy_ban— function calledtext.contains(\"ai contributions are not allowed\")but tests passed mixed-case input. Fixed to lowercase input inside the function.github::guidelines::tests::test_detects_ai_ban_llm— added pattern\b(llm|gpt|...)[-\s]+(generated|written|created)\s+(code|...). Old pattern requiredno\s+(llm|gpt|...)\s+(generated|...)which fails for "No LLM or GPT generated code".github::guidelines::tests::test_detects_ai_ban_manual_only— added patternonly\s+(accept|allow|welcome|approve)\s+(manual|human|...). Old pattern requiredmanual\s+contributions?\s+onlywhich fails for "only accept manual contributions".4. Version inconsistency (from #27)
Cargo.toml6.0.0 → 6.2.0install.shv5.2.0 → v6.2.0install.ps1v5.2.0 → v6.2.0Local verification
cargo test --lib→ 464 passed, 0 failed (was 460 passed, 4 failed)cargo clippy --lib -- -D warnings→ clean (local toolchain 1.92; 1.95 lints addressed via inspection of CI logs)cargo fmt --check→ cleanTest plan