SBP Milestone 1 review

[hbulgarini]

Sharing the same summary as tangle-network/dkg-substrate#471 since the same topics were identified in this repository:

• Usage of without_storage_info [FRAME Core] Remove without_storage_info on pallets paritytech/polkadot-sdk#323.
• Removing this will require replacing Vec with BoundedVec in storage items.
• Some docstrings seem copied from another codebase and don't match the code.
• There are some operations that might potentially panic.
• Extrinsics are now transactional by default, no need for #[transactional]
  • See Storage Layer for All FRAME Extrinsics paritytech/substrate#11431
• There are some unsafe arithmetic operations. Use of saturating_ or checked_ operations is recommended instead.

In addition, please take some time to upgrade to the latest releases. Please take into account that next releases after v0.9.30, needed some storage migrations for Weights v2, meaning that launching the parachain with this current version might involve extra work while the chain is up and running.

Please refer to the following polkadot releases analysis reports for further information:

Polkadot Release Analysis v0.9.31 & v0.9.32: https://forum.polkadot.network/t/polkadot-release-analysis/1026
Polkadot Release Analysis v0.9.33: https://forum.polkadot.network/t/polkadot-release-analysis-v0-9-33/1287
Polkadot Release Analysis v0.9.34: https://forum.polkadot.network/t/polkadot-release-analysis-v0-9-34/1432
Polkadot Release Analysis v0.9.35: https://forum.polkadot.network/t/polkadot-release-analysis-v0-9-35/1509
Polkadot Release Analysis v0.9.36: https://forum.polkadot.network/t/polkadot-release-analysis-v0-9-36/1529

[codecov-commenter]

Codecov Report

Base: 48.38% // Head: 50.63% // Increases project coverage by +2.25% 🎉

Coverage data is based on head (7ce6d62) compared to base (779162c).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     paritytech/substrate#283      +/-   ##
==========================================
+ Coverage   48.38%   50.63%   +2.25%     
==========================================
  Files          56       54       -2     
  Lines        2135     2040      -95     
==========================================
  Hits         1033     1033              
+ Misses       1102     1007      -95     

Impacted Files	Coverage Δ
pallets/asset-registry/src/lib.rs	81.86% <ø> (ø)
pallets/hasher/src/lib.rs	84.00% <ø> (ø)
pallets/key-storage/src/lib.rs	37.50% <ø> (ø)
pallets/linkable-tree/src/lib.rs	88.42% <ø> (ø)
pallets/mixer/src/lib.rs	70.09% <ø> (ø)
pallets/mt/src/lib.rs	90.00% <ø> (ø)
pallets/signature-bridge/src/lib.rs	80.51% <ø> (ø)
pallets/token-wrapper-handler/src/lib.rs	40.00% <ø> (ø)
pallets/token-wrapper/src/lib.rs	65.82% <ø> (ø)
pallets/vanchor-handler/src/lib.rs	55.00% <ø> (ø)
... and 6 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[drewstone]

@hbulgarini see the attached PR which addresses comments issued here. Let me know if that is good and we can close this!

[drewstone]

@1xstj I've closed this since the completion email but do double check we've addressed all these items.

[hbulgarini]

@1xstj I've closed this since the completion email but do double check we've addressed all these items.

very good! Thanks and good luck with the next milestone reviews!