Conversation
Contributor
Author
|
Do not merge this one yet, until @AtelyPham confirms it works for him too on the dApp. I've tested it Locally with the mentioned scripts. |
drewstone
approved these changes
Jan 3, 2024
AtelyPham
requested changes
Jan 3, 2024
AtelyPham
approved these changes
Jan 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
Changes introduced in this pull request:
Notes
I did provide two examples for claims in both Native accounts and EVM accounts
cc @AtelyPham Lmk if you will need help integrating the new format. but the tl;dr is that we now do not need the codecPrefix (i.e
0x30313031). Long version look into the diff.Reference issue to close (if applicable)
Closes #393