allow sqlify to optionally return an array of SQL commands#1780
Open
klobetime wants to merge 4 commits intotaozhi8833998:masterfrom
Open
allow sqlify to optionally return an array of SQL commands#1780klobetime wants to merge 4 commits intotaozhi8833998:masterfrom
klobetime wants to merge 4 commits intotaozhi8833998:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have SQL that has the occasional semicolon embedded. Converting this to AST is fine, but bringing it back to SQL causes issues when there are multiple SQL statements. Currently,
sqlify()uses ajoin(' ; ')to combine all the statements into a single string, but when I need to get at those asplit(';')finds those embedded semis and the results aren't what we really need.I added a new opt,
asArray, that will omit the join and give back an array of SQL commands rather than a string.