Skip to content

fix: column list include function name #2255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
taozhi8833998 merged 1 commit into from
Dec 7, 2024
Merged

fix: column list include function name #2255

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pegjs/postgresql.pegjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4547,7 +4547,7 @@ column_ref
column: { expr: col }
};
}
/ col:column_type {
/ col:column_type !LPAREN {
// => IGNORE
columnList.add(`select::null::${col.value}`);
return {
Expand Down
2 changes: 1 addition & 1 deletion pegjs/redshift.pegjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4025,7 +4025,7 @@ column_ref
column: { expr: col }
};
}
/ col:column_type {
/ col:column_type !LPAREN {
// => IGNORE
columnList.add(`select::null::${col.value}`);
return {
Expand Down
2 changes: 1 addition & 1 deletion pegjs/trino.pegjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3442,7 +3442,7 @@ column_ref
...getLocationObject()
};
}
/ col:column_type {
/ col:column_type !LPAREN {
// => IGNORE
columnList.add(`select::null::${col.value}`);
return {
Expand Down
3 changes: 3 additions & 0 deletions test/postgres.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2116,6 +2116,9 @@ describe('Postgres', () => {
}
})
expect(parser.sqlify(ast.ast, opt)).to.be.equals('SELECT "col1" + "col2" FROM "t1"')
sql = 'SELECT SUM("source"."point" + "other_source"."other_point") FROM foo';
ast = parser.parse(sql, opt)
expect(ast.columnList).to.be.eql(['select::source::point', 'select::other_source::other_point'])
})

it('should support conflict be empty', () => {
Expand Down