Skip to content

fix: Allow strings without parentheses in IN clauses #2632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sgress454 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: Allow strings without parentheses in IN clauses #2632

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pegjs/sqlite.pegjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2227,7 +2227,7 @@ in_op_right
= op:in_op __ LPAREN __ l:expr_list __ RPAREN {
return { op: op, right: l };
}
/ op:in_op __ e:(var_decl / literal_string / func_call) {
/ op:in_op __ e:(var_decl / literal_string / column_ref / func_call) {
return { op: op, right: e };
}

Expand Down
4 changes: 4 additions & 0 deletions test/sqlite.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,4 +300,8 @@ describe('sqlite', () => {
expect(getParsedSql(sql)).to.be.equal(sql)
});
});
it('should support table names with IN clauses', () => {
const sql = `SELECT * FROM pets WHERE owner_name IN people;`
expect(getParsedSql(sql)).to.be.equal('SELECT * FROM "pets" WHERE "owner_name" IN "people"')
})
})