This repository was archived by the owner on Sep 15, 2023. It is now read-only.
added readable-stream for 0.8 compat#9
Closed
rvagg wants to merge 1 commit intotapjs:masterfrom
rvagg:readable-stream
Closed
added readable-stream for 0.8 compat#9rvagg wants to merge 1 commit intotapjs:masterfrom rvagg:readable-stream
rvagg wants to merge 1 commit intotapjs:masterfrom
rvagg:readable-stream
Conversation
|
👍 I'm having failures that I trace down to this because of Travis-CI tests running 0.8 Any simple solutions? |
|
merged in 0.4.2, but now the old IE tests are breaking in <=8: https://ci.testling.com/substack/tap-parser I'll raise an issue upstream on readable-stream. |
ghost
closed this
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Anything that I use that depends on tap-parser (faucet) fails on 0.8 because of this.
Just not sure how you prefer to deal with readable-stream & browserify atm, suggestions?