Fix reproduce file formatting (use flow style)#220
Merged
Conversation
Set flow style (JSON-like) explicitly instead of block style to don't break indentation. Before the patch (incorrect): | - - app-tap/iconv.test.lua | - null After the patch: | - [app-tap/iconv.test.lua, null] The default was changed in [1]. [1]: yaml/pyyaml#256
avtikhon
approved these changes
Sep 14, 2020
Contributor
avtikhon
left a comment
avtikhon
left a comment
There was a problem hiding this comment.
Hi Alexander, thanks for the patch. I've checked the syntax, number of need entries to fix and patch in real run - all passed. Patch LGTM.
LeonidVas
approved these changes
Sep 14, 2020
Contributor
Author
|
Thanks! |
Totktonada
added a commit
to tarantool/tarantool
that referenced
this pull request
Sep 14, 2020
Fixed formatting of reproduce files with recent pyyaml versions. Background: test-run generates so called reproduce files in the test/var/reproduce/ directory and accepts them as the argument of the --reproduce option. It is convenient to share a reproducer for a problem that appears when specific tests are run in a specific order. tarantool/test-run#220
Totktonada
added a commit
to tarantool/tarantool
that referenced
this pull request
Sep 14, 2020
Fixed formatting of reproduce files with recent pyyaml versions. Background: test-run generates so called reproduce files in the test/var/reproduce/ directory and accepts them as the argument of the --reproduce option. It is convenient to share a reproducer for a problem that appears when specific tests are run in a specific order. tarantool/test-run#220 (cherry picked from commit a33cd1b)
Totktonada
added a commit
to tarantool/tarantool
that referenced
this pull request
Sep 14, 2020
Fixed formatting of reproduce files with recent pyyaml versions. Background: test-run generates so called reproduce files in the test/var/reproduce/ directory and accepts them as the argument of the --reproduce option. It is convenient to share a reproducer for a problem that appears when specific tests are run in a specific order. tarantool/test-run#220 (cherry picked from commit a33cd1b)
Totktonada
added a commit
to tarantool/tarantool
that referenced
this pull request
Sep 14, 2020
Fixed formatting of reproduce files with recent pyyaml versions. Background: test-run generates so called reproduce files in the test/var/reproduce/ directory and accepts them as the argument of the --reproduce option. It is convenient to share a reproducer for a problem that appears when specific tests are run in a specific order. tarantool/test-run#220 (cherry picked from commit a33cd1b)
Contributor
Author
|
Updated the test-run submodule in tarantool in 2.6.0-73-ga33cd1bd9, 2.5.1-72-g78b68f97c, 2.4.2-55-ged81ba6ef, 1.10.7-25-g83272871a. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set flow style (JSON-like) explicitly instead of block style to don't
break indentation.
Before the patch (incorrect):
After the patch:
- [app-tap/iconv.test.lua, null]The default was changed in 1.