Add a device to mount the host /dev/shm inside the container.#533
Add a device to mount the host /dev/shm inside the container.#533walac merged 8 commits intotaskcluster:masterfrom
Conversation
No Taskcluster jobs started for this pull requestThe `allowPullRequests` configuration for this repository (in `.taskcluster.yml` on the
default branch) does not allow starting tasks for this pull request. |
walac
left a comment
There was a problem hiding this comment.
The way it is currently implemented, the worker will lose its feature of running parallel tasks, as the device capacity will never be greater than 1
f2914fc to
3f781cd
Compare
walac
left a comment
There was a problem hiding this comment.
In general, it LGTM. I would only ask you to fix the linter complaints and add a test case. Thanks.
|
I created a PR in the community repo to add the shared memory capability scope. |
|
There is something wrong with the linter task, but I am quite sure it is unrelated to your patch. I am going to investigate it. |
|
Ok, I found out what's wrong. As you added the |
|
How do we get around this chicken-egg problem? Is there anything for me to do? |
walac
left a comment
There was a problem hiding this comment.
There is a problem while runnings tests for shm. I believe it is related to docker-in-docker. I disabled the integration test and marked the shm device support is experimental. Merging now.
We do this when fuzzing, since Firefox needs a lot of space in /dev/shm and sizing it properly is not straightforward.