Skip to content
This repository was archived by the owner on May 9, 2020. It is now read-only.

Add a device to mount the host /dev/shm inside the container.#533

Merged
walac merged 8 commits intotaskcluster:masterfrom
jschwartzentruber:add-dev-shm
Feb 3, 2020
Merged

Add a device to mount the host /dev/shm inside the container.#533
walac merged 8 commits intotaskcluster:masterfrom
jschwartzentruber:add-dev-shm

Conversation

@jschwartzentruber
Copy link
Contributor

We do this when fuzzing, since Firefox needs a lot of space in /dev/shm and sizing it properly is not straightforward.

@community-tc-integration
Copy link

No Taskcluster jobs started for this pull request
The `allowPullRequests` configuration for this repository (in `.taskcluster.yml` on the
default branch) does not allow starting tasks for this pull request.

@walac walac closed this Dec 11, 2019
@walac walac reopened this Dec 11, 2019
@walac walac self-requested a review December 11, 2019 14:15
Copy link
Contributor

@walac walac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The way it is currently implemented, the worker will lose its feature of running parallel tasks, as the device capacity will never be greater than 1

@walac walac closed this Dec 17, 2019
@walac walac reopened this Dec 17, 2019
@walac walac self-requested a review December 17, 2019 16:00
Copy link
Contributor

@walac walac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, it LGTM. I would only ask you to fix the linter complaints and add a test case. Thanks.

@walac walac self-requested a review December 18, 2019 14:54
@walac walac closed this Dec 18, 2019
@walac walac reopened this Dec 18, 2019
@walac
Copy link
Contributor

walac commented Dec 19, 2019

I created a PR in the community repo to add the shared memory capability scope.

@walac
Copy link
Contributor

walac commented Jan 7, 2020

There is something wrong with the linter task, but I am quite sure it is unrelated to your patch. I am going to investigate it.

@walac walac closed this Jan 9, 2020
@walac walac reopened this Jan 9, 2020
@walac
Copy link
Contributor

walac commented Jan 9, 2020

Ok, I found out what's wrong. As you added the hostSharedMemory to .taskcluster.yml this created a chicken-egg problem, since the currently deployed docker-worker obvisiously doesn't support this device. I wonder how tests were passing before.

@jschwartzentruber
Copy link
Contributor Author

How do we get around this chicken-egg problem? Is there anything for me to do?

@walac walac closed this Feb 3, 2020
@walac walac reopened this Feb 3, 2020
@walac walac closed this Feb 3, 2020
@walac walac reopened this Feb 3, 2020
Copy link
Contributor

@walac walac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a problem while runnings tests for shm. I believe it is related to docker-in-docker. I disabled the integration test and marked the shm device support is experimental. Merging now.

@walac walac merged commit b897eb4 into taskcluster:master Feb 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants