This repository was archived by the owner on Feb 20, 2020. It is now read-only.
WIP: Implement 1459203 (remove NSSM), 1436274 (use eventlog)#210
Closed
milescrabill wants to merge 21 commits intotaskcluster:masterfrom
milescrabill:no-more-nssm-merge-20190619
Closed
WIP: Implement 1459203 (remove NSSM), 1436274 (use eventlog)#210milescrabill wants to merge 21 commits intotaskcluster:masterfrom milescrabill:no-more-nssm-merge-20190619
milescrabill wants to merge 21 commits intotaskcluster:masterfrom
milescrabill:no-more-nssm-merge-20190619
Conversation
added 13 commits
June 27, 2019 15:31
petemoore
reviewed
Jul 2, 2019
Member
|
Nice work so far! |
added 6 commits
July 2, 2019 08:55
…er, use SKIP_ADMINISTRATOR_TESTS env var to skip service install/remove tests
…endWindowsServiceInteraction
Contributor
Author
|
Closing in favor of a branch on this repo for proper testing. |
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's a ton here. Too much!
adds dependency on
gopkg.in/natefinch/lumberjack.v2for logfile managementremoves NSSM and modifies docs, userdata in
worker_types, etc. as suchchanges the way the main
RunWorkerfunction is called for flexibility, it now accepts a signal chansplit out config handling and exit code handling into functions
adds debug logic for panic scenario exits including writing out a crash log in scenarios where other logging might be failing
support for installing/removing the generic worker service using native go
support for specifying configuration location at install time
support for windows event log when run as a service
logging to logfile by default in windows
remove need for a bat script wrapper to change the service working directory, cwd is set to parent dir of worker exe
Usage testing:
TODO:
io.Writerto thelogWriterMultiWriterwill be caught (worth testing?)lumberjack)Weird things: