Skip to content

Filling default Parameters should avoid expensive operations #616

@glandium

Description

@glandium

The default for files_changed is to do a somewhat expensive repo.get_changed_files call. It's aggravated by gecko_taskgraph having its own default that uses repo.get_locally_changed_files, which can be even more expensive.
But out-of-tree extension of the parameters schema (per extend_parameters_schema) is not the only way the value may be uselessly computed: one may call Parameters(files_changed=...), and both values that were computed above end up thrown away.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions