Skip to content

Track missed documents #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mzagozda merged 1 commit into from
Feb 24, 2026
Merged

Track missed documents #9

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 24 additions & 9 deletions Controllers/SharingController.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,12 @@ namespace Infostacker.Controllers;
public class SharingController : ControllerBase
{
private readonly ISharingService _sharingService;
private readonly ILogger<SharingController> _logger;

public SharingController(ISharingService sharingService)
public SharingController(ISharingService sharingService, ILogger<SharingController> logger)
{
_sharingService = sharingService;
_logger = logger;
}

[HttpPost("uploadmarkdownwithfiles")]
Expand All @@ -34,7 +36,7 @@ public async Task<IActionResult> GetMarkdownContent(string identifier)
string? result = await _sharingService.GetMarkdownContent(identifier);
if (result is null)
{
return NotFound(new { Message = "No markdown or files with given identifier found.", id = identifier });
return LogAndReturnNotFound("No markdown or files with given identifier found.", identifier);
}

return new ContentResult {
Expand All @@ -49,7 +51,7 @@ public async Task<IActionResult> UpdateMarkdownWithFiles([FromForm] string markd
{
if (!await _sharingService.UpdateMarkdownWithFiles(markdown, files, identifier))
{
return NotFound(new { Message = "No markdown or files with given identifier found.", id = identifier });
return LogAndReturnNotFound("No markdown or files with given identifier found.", identifier.ToString());
}

return Ok(new { Message = "Markdown and files updated successfully.", id = identifier });
Expand All @@ -61,7 +63,7 @@ public async Task<IActionResult> DeleteMarkdownWithFiles(string identifier)

if (!await _sharingService.DeleteMarkdownWithFiles(identifier))
{
return NotFound(new { Message = "No markdown or files with given identifier found.", id = identifier });
return LogAndReturnNotFound("No markdown or files with given identifier found.", identifier);
}

return Ok(new { Message = "Markdown and files successfully deleted.", id = identifier });
Expand All @@ -73,7 +75,7 @@ public async Task<IActionResult> GetPdf(string identifier, string fileName)
FileStream stream = await _sharingService.GetPdf(identifier, fileName);
if (stream is null)
{
return NotFound(new { Message = "PDF does not exist.", id = identifier });
return LogAndReturnNotFound("PDF does not exist.", identifier, fileName);
}
return File(stream, "application/pdf");
}
Expand All @@ -84,7 +86,7 @@ public async Task<IActionResult> GetDoc(string identifier, string fileName)
FileStream stream = await _sharingService.GetDoc(identifier, fileName);
if (stream is null)
{
return NotFound(new { Message = "Doc does not exist.", id = identifier });
return LogAndReturnNotFound("Doc does not exist.", identifier, fileName);
}
return File(stream, "application/vnd.openxmlformats-officedocument.wordprocessingml.document");
}
Expand All @@ -95,7 +97,7 @@ public async Task<IActionResult> GetImage(string identifier, string fileName)
FileStream stream = await _sharingService.GetImage(identifier, fileName);
if (stream is null)
{
return NotFound(new { Message = "Image does not exist.", id = identifier });
return LogAndReturnNotFound("Image does not exist.", identifier, fileName);
}
return File(stream, "image/png");
}
Expand All @@ -106,7 +108,7 @@ public async Task<IActionResult> GetVideo(string identifier, string fileName)
FileStream stream = await _sharingService.GetVideo(identifier, fileName);
if (stream is null)
{
return NotFound(new { Message = "Video does not exist.", id = identifier });
return LogAndReturnNotFound("Video does not exist.", identifier, fileName);
}
return File(stream, "video/mp4");
}
Expand All @@ -116,4 +118,17 @@ public async Task<IActionResult> GetVersion()
{
return Ok(await _sharingService.GetVersion());
}
}

private IActionResult LogAndReturnNotFound(string message, string identifier, string? fileName = null)
{
_logger.LogWarning(
"Requested resource was not found. Message: {Message}. Identifier: {Identifier}. FileName: {FileName}. Path: {Path}. TraceId: {TraceId}",
message,
identifier,
fileName,
HttpContext.Request.Path.Value,
HttpContext.TraceIdentifier);

return NotFound(new { Message = message, id = identifier });
}
}