fix(dialog): Remove Linux specific code for rfd 0.14 compatibility#1033
Conversation
|
Hi, I just stumbled upon this. It seems my PR to rfd has created a lot of unintended effects for those who use it, and I'm curious where exactly GTK documents that it's safe to run multiple event loops in the same app. The quote in PolyMeilex/rfd#152 comes from documentation that's no longer online, but I can't seem to find any other documentation that says that GTK can be run on multiple threads as long as they don't interact. If you could point me to such documentation, I may be able to create another PR to rfd. |
|
I can't remember if i based this on gtk docs or just on forum discussions (example, just for glib though) and our own testing tbh :/
In the 3 months since this was merged this did not cause a single issue that we're aware of so we're fairly confident. |
fixes #956
After PolyMeilex/rfd#152 it always freezes the app since we already have a gtk main loop running and try to run the dialog on it too. Since gtk allows to have multiple gtk event loops in the same app, as long as they run in seperate threads, i removed our special handling and let rfd spawn its own loop (see pr linked above). From my testing this works fine and allows us to keep upgrading rfd instead of locking it to 0.12(?).