Skip to content

refactor!(updater): migrate run updater using powershell to ShellExecute#1054

Merged
amrbashir merged 8 commits into
tauri-apps:v2from
Legend-Master:migrate-updater-to-shell-execute
Mar 12, 2024
Merged

refactor!(updater): migrate run updater using powershell to ShellExecute#1054
amrbashir merged 8 commits into
tauri-apps:v2from
Legend-Master:migrate-updater-to-shell-execute

Conversation

@Legend-Master
Copy link
Copy Markdown
Contributor

@Legend-Master Legend-Master commented Mar 8, 2024

Fix flashing powershell window on update

@Legend-Master Legend-Master force-pushed the migrate-updater-to-shell-execute branch from 2bac69a to f7784d0 Compare March 12, 2024 00:55
@Legend-Master Legend-Master marked this pull request as ready for review March 12, 2024 00:55
@Legend-Master Legend-Master requested a review from a team as a code owner March 12, 2024 00:55
@Legend-Master
Copy link
Copy Markdown
Contributor Author

Note: I have not tested this yet

Copy link
Copy Markdown
Member

@amrbashir amrbashir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, left a few comments for now and will test later

Comment thread plugins/updater/Cargo.toml Outdated
Comment thread plugins/updater/Cargo.toml Outdated
Comment thread plugins/updater/Cargo.toml Outdated
Comment thread plugins/updater/src/updater.rs Outdated
Comment thread plugins/updater/src/updater.rs Outdated
@Legend-Master
Copy link
Copy Markdown
Contributor Author

I doubt I did it right on the windows-sys version, felt like I was just cheating on the compiler 🤣

Comment thread plugins/updater/src/updater.rs Outdated
Comment thread plugins/updater/src/updater.rs Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants